When user selects scope aws, disable report mode #2328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmytsang
commented
Sep 28, 2023
| } | ||
| /> | ||
| </CheckBoxSectionDiv> | ||
| </SectionDiv> |
There was a problem hiding this comment.
As discussed with @MartinTrojans , the policy enforcement state radio buttons depend on the user's scope input selection therefore they should come after the scope check boxes.
Updated Form Order
MartinTrojans
approved these changes
Sep 29, 2023
Signed-off-by: jtsang01 <[email protected]>
jimmytsang
force-pushed
the
msd-policy-disable-report-mode-scope-aws
branch
from
684726d to
ef76f38
Compare
MartinTrojans
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Currently we don't support msd policies that are
scopeaws: 'true' && enforcementstate: 'report'Solution:
Initial State of add msd policy modal
User clicks on scope AWS - select
User clicks on scope AWS - deselect
User clicks on scope ALL