add scope field to microsegmentation table #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jtsang01 <[email protected]>
jimmytsang
commented
Jan 4, 2024
Comment on lines
323
to
328
| if (data && data['conditionsList']) { | ||
| data['conditionsList'].forEach((item) => { | ||
| scope = this.stringUtils.getScopeString(item); | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
@chandrasekhar1996 , from what I've noticed all the msd rules only have one item in the data['conditionsList']. Are there examples such that there are multiple items in the conditionsList?
There was a problem hiding this comment.
discussed with chandu on this and found an example with multiple items, will fix code with next commit.
added 2 commits
January 5, 2024 14:46
Signed-off-by: jtsang01 <[email protected]>
Signed-off-by: jtsang01 <[email protected]>
dantewuuuuu
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following