This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Added "g" flag to project path replacement #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add a spec testing this? |
|
Done, but sorry, I created a new file that is named "utils.js" to test the replacement function. |
|
I meant adding a test like this one, but with multiple replacements 😕. As far as I can tell your new specs are just duplicating the existing ones for the most part. Also I'd much prefer not creating a new file for a 2 line function, especially since what it does is already being tested in the |
This reverts commit 60de0ea.
|
Done. |
|
Much cleaner, thanks for sticking through with this! |
Arcanemagus
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I found multiple
$PROJECTand$PROJECT_NAMEwere not replaced properly and this PR fixes the issue.Edit (by @Arcanemagus):
Fixes #290.