Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests: fix some failing tests #13500

Merged
merged 20 commits into from
Sep 24, 2019
Merged

E2E tests: fix some failing tests #13500

merged 20 commits into from
Sep 24, 2019

Conversation

brbrr
Copy link
Contributor

@brbrr brbrr commented Sep 20, 2019

Some of the tests are started to fail:

Changes proposed in this Pull Request:

  • Scrolls Jetpack blocks group in block inserter into view before selecting a block
  • Adds some missing awaits
  • adds JS and PHP logging

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • If you're an Automattician, include a shortlink to the p2 discussion with Jetpack Product here.

Testing instructions:

  • Make sure E2E tests in CI are green

Proposed changelog entry for your changes:

@jetpackbot
Copy link
Collaborator

jetpackbot commented Sep 20, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: October 1, 2019.
Scheduled code freeze: September 24, 2019

Generated by 🚫 dangerJS against 02a6dea

@github-actions github-actions bot added the [Status] Needs Package Release This PR made changes to a package. Let's update that package now. label Sep 24, 2019
@jeherve jeherve removed the [Status] Needs Package Release This PR made changes to a package. Let's update that package now. label Sep 24, 2019
@brbrr brbrr added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Sep 24, 2019
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Sep 24, 2019
@jeherve jeherve added this to the 7.8 milestone Sep 24, 2019
@brbrr brbrr merged commit 9c90ba1 into master Sep 24, 2019
@brbrr brbrr deleted the fix/e2e-tests branch September 24, 2019 09:50
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Sep 24, 2019
jeherve pushed a commit that referenced this pull request Sep 24, 2019
* minor clean-up

* make sure Ads block is visible in inserter

* wait for selector before scrolling

* fix selector reference

* Reset page before selecting the mc list

* fix typo

* log js and php errors

* add some debugging logs

* create debug.log

* a bit more debug logging

* more debugging for wp setup

* fix typo

* Update puppeteer & fix minor stuff

* make sure Ads block is visible in inserter

* Reset page before selecting the mc list

* add some debugging logs

* create debug.log

* more debugging for wp setup

* revert some unneeded changes

* remove debug logging
@jeherve
Copy link
Member

jeherve commented Sep 24, 2019

Cherry-picked to branch-7.8 in fbc52ef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants