Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General: updated minimum required WP version to run Jetpack #13620

Merged
merged 3 commits into from
Nov 12, 2019
Merged

General: updated minimum required WP version to run Jetpack #13620

merged 3 commits into from
Nov 12, 2019

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Oct 2, 2019

Changes proposed in this Pull Request:

  • This PR does 2 things:
  1. It updates the minimum required WP version to run Jetpack, so we can remain at WP-1 when WordPress 5.3 becomes available.
  2. It removes the checks we had installed to check the installed version of PHP and pause Jetpack, since WordPress 5.2 requires PHP 5.6, which is also what Jetpack requires.

Notes

  • I am not sure we should ship this in Jetpack 7.9, since when we release it WordPress 5.3 won't be available yet. Maybe we should wait until Jetpack 8.0?
  • I'm not attached to 7955bda. I'd be happy to leave it in, just in case Jetpack decides to move away from Core's PHP requirements once again. I'm happy to revert it if needed.

Testing instructions:

  • Start on a site running WordPress 5.1
  • Add this patch
  • Jetpack will be paused

image

Proposed changelog entry for your changes:

  • General: As WordPress 5.3 is now available, Jetpack now requires WordPress 5.2.

jeherve added 2 commits October 2, 2019 09:28
@jeherve
General: update minimum supported WP version to WP -1
93e5d64
@jeherve
Remove PHP version check.
7955bda 
We don't need it anymore since Jetpack's requirements match WordPress'.
@jeherve jeherve added [Status] Needs Review This PR is ready for review. [Type] Janitorial labels Oct 2, 2019
@jeherve jeherve added this to the 7.9 milestone Oct 2, 2019
@jeherve jeherve requested review from kraftbj and a team October 2, 2019 08:06
@jeherve jeherve self-assigned this Oct 2, 2019
@jetpackbot
Copy link
Collaborator

jetpackbot commented Oct 2, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: December 3, 2019.
Scheduled code freeze: November 26, 2019

Generated by 🚫 dangerJS against 50a13ff

@jeherve jeherve modified the milestones: 7.9, 8.0 Oct 2, 2019
@jeherve
Copy link
Member Author

jeherve commented Oct 2, 2019

I am not sure we should ship this in Jetpack 7.9, since when we release it WordPress 5.3 won't be available yet. Maybe we should wait until Jetpack 8.0?

The Unit Tests agree with this, since they currently fail for the previous version of WP (5.1). I'll change the milestone to 8.0.

@kraftbj
Copy link
Contributor

kraftbj commented Oct 2, 2019

If we really wanted to, we can force Travis into listening to us, e.g. 8e0d2cd#diff-354f30a63fb0907d4ad57269548329e3

While we're touching things, I don't remember if there was a reason we said 5.6 for minimum PHP vs 5.6.20 which is WordPress' minimum now.

@jeherve
Copy link
Member Author

jeherve commented Oct 3, 2019

I don't remember if there was a reason we said 5.6 for minimum PHP vs 5.6.20 which is WordPress' minimum now.

I don't think there was.

If we really wanted to, we can force Travis into listening to us

Let's wait one month, I think that's fine. It gives folks a bit more time to upgrade.

@jeherve jeherve added [Status] Blocked / Hold and removed [Status] Needs Review This PR is ready for review. labels Oct 3, 2019
@jeherve jeherve mentioned this pull request Oct 16, 2019
Merged
@jeherve jeherve added [Status] Needs Review This PR is ready for review. and removed [Status] Blocked / Hold labels Nov 5, 2019
kraftbj
kraftbj previously approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to wait until 5.3 ships (Nov 12 ETA) before re-running Travis to actually merge.

@jeherve jeherve added [Status] Blocked / Hold [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Nov 7, 2019
@jeherve
Copy link
Member Author

jeherve commented Nov 7, 2019

On hold for now; I'll re-run the tests and merge when WordPress 5.3 is released.

@kraftbj
Copy link
Contributor

kraftbj commented Nov 12, 2019

5.3 is out, reran all tests and Travis likes.

@kraftbj kraftbj merged commit 50b080c into master Nov 12, 2019
@kraftbj kraftbj deleted the update/minimum-wp-version branch November 12, 2019 22:21
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Nov 12, 2019
lezama
lezama reviewed Nov 13, 2019
View reviewed changes
jetpack.php
*
* After both those things happen successfully, we require load-jetpack.php,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

jeherve added a commit that referenced this pull request Nov 15, 2019
@jeherve
Changelog: add #13620
6cb1953
@jeherve jeherve mentioned this pull request Nov 15, 2019
Merged
jeherve added a commit that referenced this pull request Nov 25, 2019
@jeherve
8.0 Release: running changelog (#13964)
807ab89 
* 8.0 Release: running changelog

* Changelog: add #13921

* Changelog: add #13980

* Changelog: add #13905

* Changelog: add #13971

* Changelog: add #13984

* Changelog: add #14009

* Changelog: add #13620

* Remove things that will ship in 7.9.1

* Changelog: add 7.9.1 release (#14044)

* Changelog: add base for 7.9.1 release

* Update release date and post link

* Changelog: add #14066

* Update changelog for 7.9.1

* Changelog: add #13405

* Changelog: add #13841

* Changelog: add #13924

* Changelog: add #13986

* Changelog: add #14010, #14028, #14053, #14055.

* Changelog: add #14054

* Changelog: add #14031

* Changelog: add #14039

* Changelog: add #14050

* Changelog: add #14070

* Changelog: add #14082

* Changelog: add #14084

* Changelog: add #14111

* Changelog: add #13961

* Changelog: add #14047

* Changelog: add #14091

* Changelog: add #14108

* Changelog: add #14121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lezama lezama lezama left review comments

@kraftbj kraftbj kraftbj approved these changes

Assignees

@jeherve jeherve

Labels
[Type] Janitorial
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jeherve @jetpackbot @kraftbj @lezama @matticbot