Forms: add number input #40962

simison · 2025-01-10T16:51:22Z

Proposed changes:

Adds simple number field
No min/max/step attributes for now as those can be added in follow-up PR.
Input is quite wide in editor, but how forms layout/CSS is done doesn't make it straightforward to correct. Good for follow-up PR.

Disables setting placeholders via sidebar, allowing setting them only in the editor (and thus only be number values for now) — PR for general improvement for all fields in #41712

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

In forms, add number input.
Try different default values; can be only numberic
Try setting placeholder in the editor
Try submit the input with correct and incorrect information
Try hack the values, should accept only numeric values
Try export values

Number needs to appear in several places after submitting:

Confirmation message

Email

Inbox

Export

github-actions · 2025-01-10T16:52:08Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/forms-number-input branch.
To test on Simple, run the following command on your sandbox:
```
bin/jetpack-downloader test jetpack add/forms-number-input
```

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-01-10T16:52:15Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions · 2025-02-11T10:27:25Z

Code Coverage Summary

Coverage changed in 5 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/contact-form/class-contact-form-field.php	342/507 (67.46%)	-1.16%	9 💔
projects/packages/forms/src/blocks/contact-form/class-contact-form-block.php	0/156 (0.00%)	0.00%	6 💔
projects/packages/forms/src/contact-form/class-contact-form.php	532/765 (69.54%)	-0.19%	3 ❤️‍🩹
projects/packages/forms/src/contact-form/class-contact-form-plugin.php	111/838 (13.25%)	-0.03%	2 ❤️‍🩹
projects/packages/forms/src/blocks/contact-form/child-blocks.js	0/65 (0.00%)	0.00%	1 ❤️‍🩹

Full summary · PHP report · JS report

_{Add label

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.
to override the failing coverage check.}

simison · 2025-02-11T12:27:08Z

projects/packages/forms/src/blocks/contact-form/components/jetpack-field.js

@@ -52,7 +52,8 @@ const JetpackField = props => {
 					onChange={ e => setAttributes( { placeholder: e.target.value } ) }
 					style={ fieldStyle }
 					type={ type }
-					value={ placeholder }
+					value=""
+					placeholder={ placeholder }


PR in:

Forms: use a placeholder attribute in the editor instead of value #41712

enejb · 2025-02-11T14:18:55Z

Nice work. We are getting close.

I think we still need to fix up some of the styling and make sure it looks more consistent across themes and from styles.
For example in https://wordpress.com/theme/archeo

The numbers input field looks like (across the different form styles)

There are a couple of other ones that I came across with missing styling.

lezama · 2025-02-11T14:23:15Z

projects/packages/forms/src/blocks/contact-form/child-blocks.js

+			icon: renderMaterialIcon(
+				<Path
+					fill={ getIconColor() }
+					d="M12 7H4V8.5H12V7ZM19.75 17.25V10.75H4.25V17.25H19.75ZM5.75 15.75V12.25H18.25V15.75H5.75Z"


on a follow up PR we should probably design a different icon?

lezama

looking good!

simison · 2025-02-11T16:03:46Z

@enejb can you check if you need to build forms package or Jetpack plugin? Different themes worked fine in my testing; I was basically just using the same styles as for other basic text inputs so it should look identical to other inputs in all scenarios.

Archeo, for example:

enejb · 2025-02-11T17:31:33Z

Yeah I just double checked this and it it works well in Archo theme for me now 🥳

What kinds of numbers should we allow? Do we allow only limit it to integers? How about negative numbers?

IMHO we should allows be as liberal as possible and allow any type of number by default. ( Since most folk might not think about thus much) but folks that do might want to have very specific requirements. If you add step="any" it will allow for floating point (decimals) as well.

lezama · 2025-02-12T12:09:44Z

IMHO we should allows be as liberal as possible

👍

let's merge and do follow ups?

simison · 2025-02-12T16:00:22Z

What kinds of numbers should we allow? Do we allow only limit it to integers? How about negative numbers?

I agree that's up to the site creator. :-) There will be min/max/step configuration which they can use to limit it, but not in this PR.

simison · 2025-02-12T16:01:54Z

I wanna hold off from merging until placeholder question is solved (#41712), or otherwise I'll disable placeholder UI in this PR for the Number field and add it back later.

simison · 2025-02-13T11:01:05Z

I disabled placeholder input in the sidebar for number field for now — we'll add it back with #41712

simison added [Status] In Progress [Package] Forms [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. labels Jan 10, 2025

github-actions bot added [Block] AI Assistant [Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Docs labels Jan 10, 2025

simison force-pushed the add/forms-number-input branch from 7b5380d to 975a521 Compare January 13, 2025 12:10

simison mentioned this pull request Jan 14, 2025

Forms: number field #40961

Open

8 tasks

simison force-pushed the add/forms-number-input branch from e7be37d to 2eac76d Compare February 11, 2025 10:17

simison mentioned this pull request Feb 11, 2025

Forms: fix error setting for field #41715

Merged

3 tasks

simison commented Feb 11, 2025

View reviewed changes

simison marked this pull request as ready for review February 11, 2025 12:27

simison added [Status] Needs Team Review Obsolete. Use Needs Review instead. and removed [Status] In Progress [Block] AI Assistant labels Feb 11, 2025

github-actions bot added [Block] AI Assistant [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Feb 11, 2025

simison added [Type] Feature Development of a new feature and removed [Block] AI Assistant [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Feb 11, 2025

github-actions bot added the [Block] AI Assistant label Feb 11, 2025

simison force-pushed the add/forms-number-input branch from c1d6293 to 93c3317 Compare February 11, 2025 12:31

lezama reviewed Feb 11, 2025

View reviewed changes

lezama previously approved these changes Feb 11, 2025

View reviewed changes

simison added 9 commits February 13, 2025 12:49

Forms block: add number input

8c28579

changelog

0381517

Simplify and use number type

201c7ec

Add number field to grunion CSS

78abc4a

Render input on frontend

62e267d

Use real placeholder attribute in the editor

61bdb8d

Remove number from get_field_ids

7abd1ce

Move number out of beta

f61d8ea

Disable placeholder input for number

8aea8e0

simison dismissed lezama’s stale review via 8aea8e0 February 13, 2025 10:58

simison force-pushed the add/forms-number-input branch from 455280c to 8aea8e0 Compare February 13, 2025 10:58

simison mentioned this pull request Feb 13, 2025

Forms: add min/max options to number field #41783

Merged

3 tasks

simison merged commit 7e53a77 into trunk Feb 13, 2025
64 of 65 checks passed

simison deleted the add/forms-number-input branch February 13, 2025 16:45

github-actions bot removed the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Feb 13, 2025

zinigor added this to the jetpack/14.4 milestone Feb 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Forms: add number input #40962

Forms: add number input #40962

simison commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Feb 11, 2025 •

edited

Loading

simison Feb 11, 2025

enejb commented Feb 11, 2025

lezama Feb 11, 2025

simison Feb 11, 2025

lezama left a comment

simison commented Feb 11, 2025 •

edited

Loading

enejb commented Feb 11, 2025

lezama commented Feb 12, 2025

simison commented Feb 12, 2025 •

edited

Loading

simison commented Feb 12, 2025

simison commented Feb 13, 2025 •

edited

Loading

Forms: add number input #40962

Forms: add number input #40962

Conversation

simison commented Jan 10, 2025 • edited Loading

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Jan 10, 2025 • edited Loading

github-actions bot commented Jan 10, 2025 • edited Loading

github-actions bot commented Feb 11, 2025 • edited Loading

Code Coverage Summary

simison Feb 11, 2025

Choose a reason for hiding this comment

enejb commented Feb 11, 2025

lezama Feb 11, 2025

Choose a reason for hiding this comment

simison Feb 11, 2025

Choose a reason for hiding this comment

lezama left a comment

Choose a reason for hiding this comment

simison commented Feb 11, 2025 • edited Loading

enejb commented Feb 11, 2025

lezama commented Feb 12, 2025

simison commented Feb 12, 2025 • edited Loading

simison commented Feb 12, 2025

simison commented Feb 13, 2025 • edited Loading

simison commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Feb 11, 2025 •

edited

Loading

simison commented Feb 11, 2025 •

edited

Loading

simison commented Feb 12, 2025 •

edited

Loading

simison commented Feb 13, 2025 •

edited

Loading