Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect: Fix unsupported environment notice display while toggling #41875

Conversation

dkmyta
Copy link
Contributor

@dkmyta dkmyta commented Feb 18, 2025

Fixes #
Ensure the unsupported environment notice only display in the correct conditions.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Run this branch on JT and enable Protect
  • Ensure that when you toggle Account Protection the unsupported notice does not display momentarily
  • Define the killswitch and ensure it display as expected
  • Ensure no regressions are introduced

@dkmyta dkmyta self-assigned this Feb 18, 2025
@dkmyta dkmyta changed the base branch from trunk to add/account-protection February 18, 2025 18:39
@github-actions github-actions bot added [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Status] In Progress labels Feb 18, 2025
Copy link
Contributor

github-actions bot commented Feb 18, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


🔴 Action required: Please add missing changelog entries for the following projects: projects/plugins/protect

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Protect plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Feb 18, 2025
@dkmyta dkmyta marked this pull request as ready for review February 18, 2025 18:41
Copy link
Contributor

Code Coverage Summary

No summary data is avilable for parent commit 7d83d5f, cannot calculate coverage changes. 😴

If that commit is a feature branch rather than a trunk commit, this is expected. Otherwise, this should be updated once coverage for 7d83d5f is available.

Full summary · PHP report

@@ -15,14 +16,23 @@ export default function useToggleAccountProtectionMutation(): UseMutationResult

return useMutation( {
mutationFn: API.toggleAccountProtection,
onMutate: () => {
onMutate: async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
onMutate: async () => {
onMutate: () => {

What does this change do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unintended! Not sure how that got in there 🤔

@nateweller
Copy link
Contributor

Nice fix! I'm going to go ahead and merge this into the project branch.

FYI I've opened #41878 with some small related changes.

@nateweller nateweller merged commit d507e5b into add/account-protection Feb 18, 2025
53 of 55 checks passed
@nateweller nateweller deleted the fix/protect/unsupported-environemnt-notice-display-while-toggling branch February 18, 2025 21:05
@github-actions github-actions bot removed [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Feb 18, 2025
@jeherve jeherve added the [Type] Bug When a feature is broken and / or not performing as intended label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants