Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling: Set verify-deps-before-run to install instead of warn #41996

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

tbradsha
Copy link
Contributor

Since upgrading to pnpm 10 (#41821) and setting verify-deps-before-run to warn, we often get warnings about things being outdated:

 WARN  Your node_modules are out of sync with your lockfile. The workspace structure has changed since last install

This PR switches the value to install.

Proposed changes:

Some other options considered:

  • keep value as warn: this prints to STDOUT instead of STDERR, so pollutes command substitution
  • value to false: this prevents things from being updated
  • value to prompt: might break things in non-interactive contexts, and doesn't solve the issue if someone chooses "No"

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

@tbradsha tbradsha added [Status] Needs Review This PR is ready for review. [Type] Janitorial labels Feb 24, 2025
@tbradsha tbradsha requested a review from a team February 24, 2025 15:53
@tbradsha tbradsha self-assigned this Feb 24, 2025
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@tbradsha tbradsha merged commit cc0b2b5 into trunk Feb 24, 2025
62 of 63 checks passed
@tbradsha tbradsha deleted the fix/tooling/prompt_to_update_node_modules branch February 24, 2025 16:06
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants