fix: add clear: both to global ads #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoo
approved these changes
Oct 25, 2024
|
@laurelfulford ready to merge? |
matticbot
pushed a commit
that referenced
this pull request
Nov 15, 2024
## [3.2.2-alpha.1](v3.2.1...v3.2.2-alpha.1) (2024-11-15) ### Bug Fixes * add clear: both to global ads ([#918](#918)) ([8f951b5](8f951b5))
|
🎉 This PR is included in version 3.2.2-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Nov 25, 2024
## [3.2.2](v3.2.1...v3.2.2) (2024-11-25) ### Bug Fixes * add clear: both to global ads ([#918](#918)) ([8f951b5](8f951b5))
|
🎉 This PR is included in version 3.2.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we're accounting for this in our ad insertion logic, sometimes ads end up a little too close to floated images and end up getting stuck behind them. This can happen with smaller paragraphs paired with taller images.
This PR adds a universal
clear: bothto the.newspack_global_adclass.Steps to test
The easiest way to test this might be to use some trickery:
Before this fix:
After this fix:
@kmwilkerson flagging for you in case there's any issues with these styles (like if there's a case where ads should respect and flow around floated content).