Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ras-acc) add welcome email template for checkout registration #1754

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

chickenn00dle
Copy link
Contributor

@chickenn00dle chickenn00dle commented May 30, 2024

All Submissions:

Changes proposed in this Pull Request:

Closes https://app.asana.com/0/1207385073694403/1205250932343413/f

This PR is partnered with the following main plugin PR: Automattic/newspack-plugin#3150

This adds a new welcome email template for readers who register via checkout as part of RAS-ACC.

How to test the changes in this Pull Request:

See Automattic/newspack-plugin#3150 for testing instructions.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well! Just left a couple of comments related to this feature needing to work for non-donation transactions as well.

}

\WC()->cart->empty_cart();
if ( $is_newspack_checkout ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a redundant check if not changing the condition on line 163

@chickenn00dle chickenn00dle force-pushed the feat/add-ras-welcome-email branch 2 times, most recently from cc78e2c to f850a2b Compare June 6, 2024 06:46
@chickenn00dle chickenn00dle requested a review from dkoo June 6, 2024 07:51
@chickenn00dle
Copy link
Contributor Author

@dkoo, I noticed an issue with the checkout button modal checkout throwing a session expired error in some cases so added some small changes in e8cadf2. This should be good for another round of review.

@chickenn00dle chickenn00dle force-pushed the feat/add-ras-welcome-email branch 2 times, most recently from a1632aa to 724e2a5 Compare June 7, 2024 07:51
@chickenn00dle chickenn00dle force-pushed the feat/add-ras-welcome-email branch from 724e2a5 to 84116ff Compare June 18, 2024 18:25
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working now!

@chickenn00dle chickenn00dle merged commit 494b930 into epic/ras-acc Jun 26, 2024
8 checks passed
@chickenn00dle chickenn00dle deleted the feat/add-ras-welcome-email branch June 26, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants