-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ras-acc) add welcome email template for checkout registration #1754
Conversation
0075cb2
to
62ab080
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working well! Just left a couple of comments related to this feature needing to work for non-donation transactions as well.
} | ||
|
||
\WC()->cart->empty_cart(); | ||
if ( $is_newspack_checkout ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a redundant check if not changing the condition on line 163
cc78e2c
to
f850a2b
Compare
a1632aa
to
724e2a5
Compare
724e2a5
to
84116ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working now!
All Submissions:
Changes proposed in this Pull Request:
Closes https://app.asana.com/0/1207385073694403/1205250932343413/f
This PR is partnered with the following main plugin PR: Automattic/newspack-plugin#3150
This adds a new welcome email template for readers who register via checkout as part of RAS-ACC.
How to test the changes in this Pull Request:
See Automattic/newspack-plugin#3150 for testing instructions.
Other information: