Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ras-acc): hide NYP on billing screen #1763

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR just re-adds a NYP show/hide code that I think was removed accidentally when different commits came together.

See: 1205234045751551-1207500552150790

How to test the changes in this Pull Request:

  1. On epic/ras-acc, set up a Checkout Button block with a NYP product.
  2. Run through the checkout; note that the NYP input appears on both the Billing and Order Details screens:

Screen Shot 2024-06-06 at 1 06 34 PM

  1. Apply this PR and run npm run build.
  2. Re-run the checkout, and confirm that the NYP field only shows on the second Order Details screen, and not on the Billing Details screen.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@chickenn00dle chickenn00dle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @laurelfulford

@laurelfulford
Copy link
Contributor Author

Thanks @chickenn00dle! 🙌

@laurelfulford laurelfulford merged commit eafa518 into epic/ras-acc Jun 7, 2024
9 checks passed
@laurelfulford laurelfulford deleted the fix/nyp-field branch June 7, 2024 16:15
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.3.0-epic-ras-acc.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants