Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal-checkout): allow metorik scripts #1976

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

The Metorik (WC tracking) scripts have to be allowed to load on WC pages for the tracking to work.

How to test the changes in this Pull Request:

  1. On the base branch, load the /checkout/?modal_checkout=1 page, observe the metorik JS is not loaded
  2. Switch to this branch, observe it's loaded

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch and the fix, @adekbadek! 🙌

@laurelfulford laurelfulford merged commit 67276ce into epic/ras-acc Nov 27, 2024
9 checks passed
@laurelfulford laurelfulford deleted the fix/allow-metorik-on-checkout branch November 27, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants