fix(ras-acc): respect social icons padding #1615
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Closes https://app.asana.com/0/1207817176293825/1207990881852220/f
This PR addresses an issue where the renderer was not not respecting the social icons padding set in the editor. This also tweaks the default icons padding to 8px (from 7px) to be in-line with the spacing set in RAS-ACC transactional emails:
Editor:

Email:

How to test the changes in this Pull Request:
To test this PR, be sure to also checkout the following plugin PR: Automattic/newspack-plugin#3339
See Automattic/newspack-plugin#3339 for testing RAS-ACC specific behavior
trunk
Note that social icons in newsletters is currently a bit funky on
trunk
. This PR does not fix this and only focuses on changes for RAS-ACC.Other information: