Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(woocommerce): fix order-pay page when using woocommerce-membershi… #2923

Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix(woocommerce): fix order-pay page when using woocommerce-membershi… #2923

merged 1 commit into from
Feb 15, 2024

Conversation

adekbadek
Copy link
Member

@adekbadek adekbadek commented Feb 13, 2024 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Fixes an issue with the woocommerce-memberships-for-teams plugin when attempting to complete a pending-payment order.

See 1200550061930446-as-1206314181096660

How to test the changes in this Pull Request:

  1. Activate woocommerce-memberships-for-teams on top of regular Newspack & Woo setup
  2. Edit the monthly donation product and tick "Team membership" checkbox:
image
  1. Create a membership plan with access based on buying a recurring donation product
  2. Make a monthly donation as a new user, then as admin manually update the order status to "Pending payment"
  3. Visit the "Customer payment page" (when logged in as the customer)
  4. On release -> observe the cart is emptied and you cannot pay for the order
  5. Switch to this branch, visit the payment page link again, observe a regular Woo cart experience*

* you won't be able to actually pay because of the manual setting of 'pending payment' status

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Feb 13, 2024
@adekbadek adekbadek requested a review from a team as a code owner February 13, 2024 08:44
@adekbadek adekbadek force-pushed the hotfix/wc-teams-memberships-renewal branch from 23aed73 to 36093d9 Compare February 13, 2024 09:02
chickenn00dle
chickenn00dle reviewed Feb 14, 2024
View reviewed changes
Copy link
Contributor

@chickenn00dle chickenn00dle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not able to reproduce the issue on release branch locally.

Here is a pending order for my monthly donation product:
Screenshot 2024-02-14 at 11 24 28

And the associated membership:
Screenshot 2024-02-14 at 11 25 19

And finally when I open the Customer payment page link while logged in as the customer, I am redirected to checkout with no errors:
Screenshot 2024-02-14 at 11 27 02

Is there a missing step to reproduce?

@adekbadek
Copy link
Member Author

Is there a missing step to reproduce?

Yes! Sorry for that. I've updated the description (added step 2).

chickenn00dle
chickenn00dle approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@chickenn00dle chickenn00dle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks @adekbadek 🙌

I'm able to reproduce now and can confirm the fix. I'm gonna go ahead and approve since there is a publisher waiting for it, but I'm wondering if this should be submitted as a fix in the memberships for teams repo? At least it seems like the issue is self contained within that plugin.

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Feb 15, 2024
@adekbadek
Copy link
Member Author

It's closed-source, might be worth reaching out via some channel though.

@dkoo dkoo merged commit e87e2dc into release Feb 15, 2024
8 checks passed
@dkoo dkoo deleted the hotfix/wc-teams-memberships-renewal branch February 15, 2024 18:02
matticbot pushed a commit that referenced this pull request Feb 15, 2024
@semantic-release-bot
chore(release): 3.0.4 [skip ci]
3397dff 
## [3.0.4](v3.0.3...v3.0.4) (2024-02-15)

### Bug Fixes

* **woocommerce:** fix order-pay page when using woocommerce-memberships-for-teams plugin ([#2923](#2923)) ([e87e2dc](e87e2dc))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.0.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Feb 20, 2024
@semantic-release-bot
chore(release): 3.1.0-alpha.5 [skip ci]
de79b13 
# [3.1.0-alpha.5](v3.1.0-alpha.4...v3.1.0-alpha.5) (2024-02-20)

### Bug Fixes

* **perfmatters:** use ignore-defaults constant when applying unused CSS ([#2863](#2863)) ([6d52be3](6d52be3))
* **woocommerce:** fix order-pay page when using woocommerce-memberships-for-teams plugin ([#2923](#2923)) ([e87e2dc](e87e2dc))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.1.0-alpha.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@naxoc naxoc mentioned this pull request Feb 14, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chickenn00dle chickenn00dle chickenn00dle approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adekbadek @matticbot @chickenn00dle @dkoo