Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: IA Setup Wizard #3572

Closed
wants to merge 1 commit into from
Closed

Feat: IA Setup Wizard #3572

wants to merge 1 commit into from

Conversation

ronchambers
Copy link
Collaborator

@ronchambers ronchambers commented Nov 25, 2024

Draft: initial dev and local testing.

Notes:

  • Moved define( 'NEWSPACK_SETUP_COMPLETE', 'newspack_setup_complete' ); to a more global position (outside the setup class) so it can be more clearly used by other classes.
  • Since the slug was changed from admin.php?page=newspack to admin.php?page=newspack-dashboard some clean up was needed in other places. (Otherwise we'll need to rollback the slug to just newspack).
  • Moved the setup wizard's instantiation to after dashboard so that the main Newspack menu is created prior to the "Setup" submenu item being added. Also set $admin_menu_priority = 2; for extra safety.
  • I assumed the Advertising and Audience menus shouldn't appear until after Setup is complete....but please verify.

All Submissions:

Changes proposed in this Pull Request:

Closes # .

How to test the changes in this Pull Request:

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@ronchambers ronchambers changed the base branch from trunk to epic/ia November 25, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants