fix(recaptcha): add safeguards against duplicate recaptcha rendering #3624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chickenn00dle
added
the
[Status] Needs Review
6 tasks
chickenn00dle
changed the title
dkoo
approved these changes
Dec 13, 2024
github-actions
bot
added
[Status] Approved
matticbot
pushed a commit
that referenced
this pull request
Dec 13, 2024
## [5.9.2](v5.9.1...v5.9.2) (2024-12-13) ### Bug Fixes * **recaptcha:** add safeguards against duplicate renders ([#3624](#3624)) ([d95ee7e](d95ee7e))
|
🎉 This PR is included in version 5.9.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Dec 16, 2024
# [5.10.0-alpha.2](v5.10.0-alpha.1...v5.10.0-alpha.2) (2024-12-16) ### Bug Fixes * dont load textdomain too early ([#3629](#3629)) ([76c1f97](76c1f97)) * hide duplicate notices if all was dismissed ([#3630](#3630)) ([cf48188](cf48188)) * **recaptcha:** add safeguards against duplicate renders ([#3624](#3624)) ([d95ee7e](d95ee7e))
|
🎉 This PR is included in version 5.10.0-alpha.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Closes https://app.asana.com/0/1207817176293825/1208950357031079/f
This PR adds some safeguards to protect against potential duplicate rendering in recaptcha logic. We also make the recaptcha message a bit clearer to indicate the problem is connecting to recaptcha.
How to test the changes in this Pull Request:
Other information: