This repository has been archived by the owner on Feb 17, 2025. It is now read-only.
Videomaker: fixing fonts path #5711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we change Videomaker to use fonts like this? |
Yeah I think that's a good idea. |
|
Mmmh, we might break the customizer options if we do that though! maybe it's not such a good idea until the Jetpack font selector is ready for users on dotcom. |
|
Oh good point! Maybe we should wait then. |
|
I agree that Blockbase themes should wait for some font management solution before we upgrade this. Change looks good. I think we should ship it. |
pbking
approved these changes
Mar 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Videomaker fixes for:
*.var.*) causes 500 Internal Server Error on Apache web server philipbelesky/inter-ui#17Related issue(s):
#5661