This repository has been archived by the owner on Feb 17, 2025. It is now read-only.
[Archeo] Tidy up the main homepage pattern #5716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
added
[Type] Enhancement
|
@mikachan: One other thing to note: For some reason this isn't loading the Chivo font anymore on my local install? I'm not sure if that's just a problem on my end, or something more widespread. |
mikachan
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
Thanks for doing this, all these changes look good to me and this definitely looks better at mobile.
For the fonts, we've just merged a change that moves their settings into theme.json. Are you using the latest GB trunk?
I'm not! So I'm sure that's the problem. 👍 Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we switched to using columns for the pattern on top of the homepage, its mobile behavior degraded. This PR fixes that up a bit. As part of the fix, I swapped the order of the image, which resulted in me needing to adjust the screenshot too.
Screenshots