Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Site Editing: Replace save buttons with temporary attribute changes [1] #34287

Closed
glendaviesnz opened this issue Jun 25, 2019 · 0 comments · Fixed by #34350
Closed

Full Site Editing: Replace save buttons with temporary attribute changes [1] #34287

glendaviesnz opened this issue Jun 25, 2019 · 0 comments · Fixed by #34350

Comments

@glendaviesnz
Copy link
Contributor

glendaviesnz commented Jun 25, 2019

Currently the Site Description and Site Title FSE blocks have their own save buttons, as changes to these blocks do not update the editor dirty state.

After discussion at paAmJe-tF-p2 about better solutions to this it was decided to remove the save buttons on both of these blocks and instead use a temporary attribute value that can be updated on changes in order to indicate dirty state to the editor.

Example implementation.

This is a temporary fix to this issue while the generalisation of custom sources is worked on in the core editor (WordPress/gutenberg#16075) and the subsequent adding of a site options source as a more permanent solution.

@vindl vindl changed the title Full Site Editing: Replace save buttons with temporary attribute changes Full Site Editing: Replace save buttons with temporary attribute changes [?] Jun 27, 2019
@vindl vindl added this to the Cylon+Serenity Sprint [27-28] milestone Jun 27, 2019
@glendaviesnz glendaviesnz self-assigned this Jun 27, 2019
@glendaviesnz glendaviesnz changed the title Full Site Editing: Replace save buttons with temporary attribute changes [?] Full Site Editing: Replace save buttons with temporary attribute changes [1] Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants