Replace FSE block save buttons with temporary fake setAttribute call #34350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to force editor dirty state
glendaviesnz
added
the
[Status] Needs Review
glendaviesnz
commented
Jun 28, 2019
| // The following is a temporary fix. Setting this fake attribute is used to flag | ||
| // the content as dirty to editor and enable Update/Publish button. This should be | ||
| // removed once updating of site options handled in core editor | ||
| setAttributes( { updated: Date.now() } ); |
There was a problem hiding this comment.
It is interesting that this works to flag the editor state as dirty, even though the fse blocks do not have any attributes set and so this doesn't actually update any attribute data in the block content.
There was a problem hiding this comment.
I think it's ok to use this hack while we confirm if the Gutenberg behavior here is deliberate or not (paAmJe-tF-p2 #comment-1329).
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
glendaviesnz
added
[Status] In Progress
and removed
[Status] Needs Review
mmtr
approved these changes
Jun 28, 2019
| // The following is a temporary fix. Setting this fake attribute is used to flag | ||
| // the content as dirty to editor and enable Update/Publish button. This should be | ||
| // removed once updating of site options handled in core editor | ||
| setAttributes( { updated: Date.now() } ); |
There was a problem hiding this comment.
I think it's ok to use this hack while we confirm if the Gutenberg behavior here is deliberate or not (paAmJe-tF-p2 #comment-1329).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Testing instructions
Fixes #34287