Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dotcom FSE: remove close button on Gutenberg 7.7 #40334

Closed
vindl opened this issue Mar 20, 2020 · 3 comments · Fixed by #40329
Closed

Dotcom FSE: remove close button on Gutenberg 7.7 #40334

vindl opened this issue Mar 20, 2020 · 3 comments · Fixed by #40329
Assignees
Labels
[Goal] Full Site Editing [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug When a feature is broken and / or not performing as intended

Comments

@vindl
Copy link
Member

vindl commented Mar 20, 2020

Out custom functionality to remove the default back button and replace it with our custom one doesn't work with Gutenberg 7.7 update. We need to update the functionality in order to remove the newly added W close button:

Screenshot 2020-03-20 at 14 56 40

Our custom button is still inserted correctly but there is a styling issue with the right border that should be addressed as part of this task.

@vindl vindl added [Type] Bug When a feature is broken and / or not performing as intended [Pri] High Address as soon as possible after BLOCKER issues [Goal] Full Site Editing labels Mar 20, 2020
@simison
Copy link
Member

simison commented Mar 20, 2020

@razvanpapadopol mentioned he could get this fixed. @razvanpapadopol do update here how it goes so that US folks can continue tackling it over their timezones as well. :-)

@mtias
Copy link
Member

mtias commented Mar 21, 2020

Why wouldn't we use the W instead of the custom button?

@vindl
Copy link
Member Author

vindl commented Mar 21, 2020

Why wouldn't we use the W instead of the custom button?

@mtias we'll use it in general, this is just for the subset of legacy dotcom FSE sites, which is not that big in comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Full Site Editing [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants