[Gutenberg 7.7.1]: Fix editor close button

[razvanpapadopol]

Changes proposed in this Pull Request

Block editor updates:

• update function to close editor and ignore existing URL
• update tracking
• update e2e gutenberg lib

FSE updates:

• remove W button
• fix back button positioning

Testing instructions

Here is a diff for testing the wpcom-block-editor: D40709-code.

Checkout this PR locally and sync wp-block-editor widget and FSE plugin using FSE Plugin Development instructions in FG.

• On a non-FSE site start editing a page or post.
• Pressing on top-left W button should close the editor.
• On a FSE enabled site, go to /block-editor/page/[EDGE_STICKERED_SITE].wordpress.com
• There shouldn't be any W button
• [Backward compatibility] On a site running the previous version of Gutenberg everything should look and work the same as before.

Follow up:

• fix editor header positioning for smaller screens Gutenberg 7.7.1 update on wpcom: fix header position on mobile #40335

Fixes #40315, Fixes #40334
Part of: #40078

[matticbot]

Test live: https://calypso.live/?branch=fix/gutenberg-7.7-w-back-button

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello razvanpapadopol! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D40617-code before merging this PR. Thank you!

[vindl]

LGTM!

[vindl]

Just a note that we'll have to be careful with deployment order here. Block editor diff should probably land around the same time we land Gutenberg plugin update, and at that time we should also sync FSE new plugin version containing these changes.

[simison]

Remember that Atomic users can have older Gutenberg version so we should support both for a while.

I think there is a window global for the version?

[noahtallen]

wpcomGutenberg.pluginVersion should work. Only in the iFrame, I think.

[noahtallen]

I think instead of detecting the version, we could just keep both .css selectors instead of removing the old .css selectors.

[noahtallen]

If we merge the PR with support for 7.3, then it can be deployed before releasing 7.7.1 (which is ideal, as we don't want the back button to stop working for some gap period of time)

[noahtallen]

I "audited" the different classnames to see which ones should work for WP 5.4 AND Gutenberg 7.7.1+, and which ones are fine to drop compatibility with WP 5.4.

It might cause some visual inconsistency in dotcom-FSE if you've turned of the Gutenberg plugin. But honestly, the plugin is designed to only work with the latest version, and there aren't a large enough number of people using it in the first place. So the subset that could see weird visual things is pretty small (i.e. Atomic user who has kept their original theme and has turned off the Gutenberg plugin).

I did test that this fixes the FSE back button issues on 7.7.1, but I didn't get a chance to test the wpcom fixes. They look good to me though :)

[noahtallen]

I did a lot of testing for this PR, and it works fantastically. It can be shipped immediately to simple sites and to FSE

By the way, I also created this diff for the wpcom block editor changes. That can be done at any time now that this works for the old and new versions: D40709-code.

dotcom-fse

With Gutenberg edge:
✅ SPT navigation on new pages
✅ navigating back from new/existing pages
✅ navigating to and back from template parts like the header/footer
✅ back from new and existing posts

Without Gutenberg edge:
✅ SPT navigation on new pages
✅ navigating back from new/existing pages
✅ navigating to and back from template parts like the header/footer
✅ back from new and existing posts

non-fse/normal sites

With Gutenberg edge:
✅ SPT navigation on new pages
✅ navigating back from new/existing pages
✅ back from new and existing posts

Without Gutenberg edge:
✅ SPT navigation on new pages
✅ navigating back from new/existing pages
✅ back from new and existing posts