WIP: Allow createSelector to store a cache
#21547
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
commented
Jan 15, 2018
| @@ -139,7 +140,7 @@ export function buildExportArray( data, parent = null ) { | |||
| * @return {String} Serialized stats query | |||
| */ | |||
| export function getSerializedStatsQuery( query = {} ) { | |||
| return JSON.stringify( sortBy( toPairs( query ), pair => pair[ 0 ] ) ); | |||
| return deterministicStringify( query ); | |||
There was a problem hiding this comment.
oops. this wasn't necessary for this PR but it was in my stash
dmsnell
force-pushed
the
refactor/create-selector-store-moar
branch
from
807c940 to
787a31a
Compare
`createSelector` has a big problem: it invalidates its cache way too frequently. It does this whenever dependants change, but it's not comparing those dependants against the called parameters - it's applying them "globally" within the selector such that even when the underlying data in `state` is the same, because the selector was invoked with different parameters it generates different dependants and thinks things are different. This change caches the dependants per cache key so we don't need to clear so often. This introduces memory bloat because we're storing those cached values throughout the session.
dmsnell
force-pushed
the
refactor/create-selector-store-moar
branch
from
787a31a to
c9c0203
Compare
|
Closing because people didn't want to investigate if this is a problem and I am too busy to do it myself. |
|
What was this meaning to resolve which wasn't already covered by #20547 ? Possibly of interest: aduth/rememo#1 , which achieves a bit of both between Calypso's |
|
@aduth it was trying to resolve the question of how much our current use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@see #20330 which is basically the same except this PR makes the behavior global and default
@see #20547 which provides an explicit and robust way of caching
createSelectorhas a big problem: it invalidates its cache way toofrequently. It does this whenever dependants change, but it's not
comparing those dependants against the called parameters - it's applying
them "globally" within the selector such that even when the underlying
data in
stateis the same, because the selector was invoked withdifferent parameters it generates different dependants and thinks things
are different.
This change caches the dependants per cache key so we don't need to
clear so often. This introduces memory bloat because we're storing those
cached values throughout the session.