Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg 7.7.1: Trigger E2E tests #39292

Closed
wants to merge 1 commit into from

Conversation

andrewserong
Copy link
Member

@andrewserong andrewserong commented Feb 6, 2020

E2E integration tests against Gutenberg Edge.

Fixes in #40239

@andrewserong andrewserong added DO NOT MERGE [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot labels Feb 6, 2020
@matticbot
Copy link
Contributor

@andrewserong andrewserong self-assigned this Feb 6, 2020
@andrewserong andrewserong requested a review from a team February 6, 2020 04:38
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@andrewserong andrewserong mentioned this pull request Feb 6, 2020
16 tasks
@p-jackson p-jackson added [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot and removed [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot labels Feb 14, 2020
@ramonjd ramonjd added [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot and removed [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot labels Feb 26, 2020
@ramonjd ramonjd changed the title Gutenberg 7.4.0: Trigger E2E tests Gutenberg 7.6.0-rc-1: Trigger E2E tests Feb 26, 2020
@ramonjd
Copy link
Member

ramonjd commented Feb 26, 2020

Re-triggering the tests to run against the recently launched 7.6.0-rc.1

See: #39689

@ramonjd
Copy link
Member

ramonjd commented Feb 27, 2020

To fix:

TimeoutError: Timed out waiting for element with css selector of '.dashicons-no-alt' to be clickable

https://app.circleci.com/jobs/github/Automattic/wp-e2e-tests-for-branches/50326

Because of this change

https://github.com/WordPress/gutenberg/pull/19959/files#diff-b1dcc68a57b0f94413a4e191bc161f8dR82

Affected test code

await driverHelper.clickWhenClickable( this.driver, By.css( '.dashicons-no-alt' ) );

Suggested fix

Click on .editor-post-publish-panel__header-publish-button + .components-button.has-icon

Screen Shot 2020-02-27 at 2 52 37 pm


TimeoutError: Timed out waiting for element with css selector of '.editor-post-preview' to be clickable

https://app.circleci.com/jobs/github/Automattic/wp-e2e-tests-for-branches/50326

Because of this change

https://github.com/WordPress/gutenberg/pull/19082/files#diff-f46eebd6e860a1b5b5f823f6de751a55R188

Affected test code

By.css( '.editor-post-preview' ),

Suggested fix

Click on .editor-post-preview__dropdown to show the preview drop down

Screen Shot 2020-02-27 at 2 48 53 pm

Then click on .editor-post-preview__button-external (the preview link at the bottom of the menu)


Timed out waiting for element with css selector of '.editor-simple-payments-modal' to NOT be present

Unsure of this one.

First seen at https://app.circleci.com/jobs/github/Automattic/wp-e2e-tests-for-branches/50575

Because of this change

Still looking...

Affected test code

await gPaymentComponent.insertPaymentButtonDetails( paymentButtonDetails );

return await driverHelper.waitTillNotPresent(

Suggested fix

SimplePaymentsBlockComponent extends GutenbergBlockComponent which extends AsyncBaseContainer

AsyncBaseContainer.insertPaymentButton might need to be overwritten in GutenbergBlockComponent maybe. Not sure if we're evening calling it in the Gutenberg tests.

@ramonjd ramonjd mentioned this pull request Mar 11, 2020
23 tasks
@ramonjd ramonjd removed the request for review from a team March 11, 2020 23:08
@ramonjd ramonjd changed the title Gutenberg 7.6.0-rc-1: Trigger E2E tests Gutenberg 7.7.0: Trigger E2E tests Mar 11, 2020
@ramonjd ramonjd changed the title Gutenberg 7.7.0: Trigger E2E tests Gutenberg 7.7.1: Trigger E2E tests Mar 13, 2020
@ramonjd ramonjd requested a review from a team March 13, 2020 00:14
@ramonjd
Copy link
Member

ramonjd commented Mar 13, 2020

Going to trigger to run 7.7.1

See: #40078

@ramonjd ramonjd added [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot labels Mar 13, 2020
@ramonjd ramonjd removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 18, 2020
@simison simison added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot and removed [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot labels Mar 25, 2020
@noahtallen
Copy link
Contributor

closed in favor of #40451

@noahtallen noahtallen closed this Apr 6, 2020
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 6, 2020
@worldomonation worldomonation deleted the test/gutenberg-edge-v7.4.0 branch September 27, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants