Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove margin-left override on block-editor-inserter__toggle in wpcom-block-editor #41392

Merged

Conversation

andrewserong
Copy link
Member

@andrewserong andrewserong commented Apr 23, 2020

This removes the left margin override on the block inserter in the header within the editor (The big plus button), which should return the alignment to match what's in core, and also resolve a mobile styling issue with this button.

Before

Mobile

image

Desktop

image

After

Mobile

image

Desktop

image

Changes proposed in this Pull Request

Testing instructions

image

Fixes #41386

@andrewserong andrewserong requested review from a team as code owners April 23, 2020 04:55
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@andrewserong andrewserong added the [Type] Bug When a feature is broken and / or not performing as intended label Apr 23, 2020
@andrewserong andrewserong requested review from alshakero and a team April 23, 2020 05:15
@andrewserong andrewserong self-assigned this Apr 23, 2020
@andrewserong andrewserong added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 23, 2020
Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on D42316-code

LGTM

Copy link
Member

@alshakero alshakero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected ✨

@andrewserong andrewserong force-pushed the fix/wpcom-block-editor-margin-left-on-inserter-toggle branch from 530fcbb to e98a83f Compare April 27, 2020 00:30
@andrewserong andrewserong merged commit 5570091 into master Apr 27, 2020
@andrewserong andrewserong deleted the fix/wpcom-block-editor-margin-left-on-inserter-toggle branch April 27, 2020 01:16
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove header padding override introduced in #40361
4 participants