Site Editor tracking e2e - Fix broken template part test #55247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addison-Stavlo
requested review from
scinos,
WunderBart and
a team
as code owners
matticbot
added
the
[Status] Needs Review
|
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-12368 |
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
dpasque
approved these changes
Aug 6, 2021
Addison-Stavlo
added
[Status] Needs e2e Testing horizon
jeyip
approved these changes
Aug 6, 2021
Addison-Stavlo
deleted the
fix/site-editor-tracks-e2e-choose-existing-template-part-test
branch
github-actions
bot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Due to a change in our Header patterns combined with a bug in core causing an undo trap (related WordPress/gutenberg#33908), the "choose existing" template part test is now failing since it relied on the 'undo' action to get to its starting state.
Here, the simple fix is to just insert a new Header block instead of relying on undo.
Update - I found a later test failing due to the selector for the search input changing. We update that selector to the new class name as well.
Testing instructions
addBlockactions will fail.Related to #