Add the lists of public rooms on the server #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase this onto the latest |
|
Ok, I have done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/_matrix/client/r0/publicRoomsRelated: #100
Missing feature: pagination and filter
The feature can be improved in the future
Pagiation is not easy because of special token for next and previous results.
IMO the dataprovider must be extended to store the token for pagination e.g. in local store, memory, URL or somewhere else.
https://matrix.org/docs/spec/client_server/latest#get-matrix-client-r0-publicrooms
next_batchandprev_batchUpgrade to react-admin 3.12.2 is necessary. Because of an fixed bug
Fix <DeleteWithConfirmButton> does not allow to override resourcehttps://github.com/marmelab/react-admin/releases/tag/v3.12.2