Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Architecture Center - Style Formatting #10

Merged
merged 11 commits into from
Jan 10, 2024
Merged

Azure Architecture Center - Style Formatting #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
06c11a5
markdown updates
ckittel Jan 5, 2024
6c52750
change icon
ckittel Jan 5, 2024
ff66148
add spaces
ckittel Jan 5, 2024
cebb4d4
AAD -> Entra
ckittel Jan 5, 2024
df5b78d
a few more entra usages
ckittel Jan 5, 2024
78b4629
Minor formatting
ckittel Jan 5, 2024
f2869d9
add back TOC
ckittel Jan 5, 2024
9fc3bff
sentence
ckittel Jan 5, 2024
5e399cf
Apply suggestions from code review
ckittel Jan 8, 2024
88e1c08
more codeblock cleanups
ckittel Jan 8, 2024
dabf0b2
A few more codeblock formats
ckittel Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/deployAzGovViz.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# First things first:
# 1. Mandatory: define <Management Group Id> in line 11
# 2. Optional: enable the schedule (line 22,23)
# Documentation: https://github.com/JulianHayward/Azure-MG-Sub-Governance-Reporting
# Documentation: https://github.com/Azure/Azure-Governance-Visualizer

name: DeployAzGovViz

Expand Down Expand Up @@ -127,8 +127,8 @@ jobs:
}
}
else {
Write-Host 'Assuming and insisting that you do not want to publish your tenant insights to the public'
Write-Host "HTML NOT published. Please configure authentication on the webApp ($($env:WebAppName))"
Write-Host 'Assuming and insisting that you do not want to publish your tenant insights to the public.'
Write-Host "HTML NOT published. Please configure authentication on the Azure Web App ($($env:WebAppName))."
exit 1
}
azPSVersion: "latest"
2 changes: 1 addition & 1 deletion .github/workflows/deployAzGovVizAccelerator.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ jobs:
subscriptionId: ${{ secrets.SUBSCRIPTION_ID }}
resourceGroupName: ${{vars.RESOURCE_GROUP_NAME}}
template: ./bicep/webApp.bicep
parameters: ./bicep/webApp.parameters.json webAppName=${{vars.WEB_APP_NAME}} managementGroupId=${{secrets.MANAGEMENT_GROUP_ID}} clientId=${{ secrets.AAD_CLIENT_ID }} clientSecret=${{ secrets.AAD_CLIENT_SECRET }}
parameters: ./bicep/webApp.parameters.json webAppName=${{vars.WEB_APP_NAME}} managementGroupId=${{secrets.MANAGEMENT_GROUP_ID}} clientId=${{ secrets.ENTRA_CLIENT_ID }} clientSecret=${{ secrets.ENTRA_CLIENT_SECRET }}
failOnStdErr: false

Loading