-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App service machine learning landing zone support #127
Conversation
…linux container support
A few pending work items should be done prior to approval, but require review first:
In addition, App Service could have access restrictions and private endpoint for inbound traffic. Though for this pull request I'm leaving it out of scope and would suggest it be addressed in a separate issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
App Service as a the model runtime is a great alternative. A few suggested changes so that the parameters are more explicit on the intent.
… and added enabled t/f support for aks and app service
schemas/latest/landingzones/types/appServiceLinuxContainer.json
Outdated
Show resolved
Hide resolved
I've left comments on small fixes to the templates. Can you please add test cases for when aks.enabled = false and appService.enabled = false. We can then add these test cases as deployment scenarios in docs/archetypes/machinelearning.md#deployment-scenarios |
Co-authored-by: Senthuran Sivananthan <[email protected]>
…bSecALZ into app-service-ml-lz
Co-authored-by: Senthuran Sivananthan <[email protected]>
Co-authored-by: Senthuran Sivananthan <[email protected]>
I've successfully tested the following 3 deployment scenarios:
|
…yment, changed default sku to p1v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for the enhancement & additional deployment validation @hudua.
#approved
Overview/Summary
Added optional support for App Service (Linux container) in machine learning landing zone, so that model deployment can be to app service, instead of AKS. This way Azure ML can be used for model training and push a containerized model to Azure Container Registry with private endpoint. Then App Service (Linux container) can pull from the registry and run the model as a service.
This resolves issue #93
This PR fixes/adds/changes/removes
tests/schemas/run-tests.sh
testtests/landingzones/lz-machinelearning/deployment-tests
Breaking Changes
Backwards compabilities may be affected per:
enabled
field for AKS config fileintegration
subnet due to app service vnet integration delegation requirementTesting Evidence
App service deployed:
Using Linux publicly available container:
mcr.microsoft.com/appsvc/staticsite:latest
Virtual network integration set
As part of this Pull Request I have
main
branch