Fix BodyTopLevelPropertiesOnly to support get-only APIs #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdefoy
requested review from
rkmanda,
konrad-jamrozik,
mikeharder and
weshaggard
as code owners
bdefoy
commented
Jun 13, 2024
mikeharder
requested changes
Jun 13, 2024
mikeharder
requested changes
Jun 13, 2024
There was a problem hiding this comment.
I think you also want to bump the package version here, so you can publish a new version after merging:
https://github.com/azure/azure-openapi-validator/blob/main/packages/rulesets/package.json#L3
konrad-jamrozik
approved these changes
Jun 14, 2024
|
@bdefoy note the current deployment process is here: |
mikeharder
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BodyTopLevelProperties currently does not catch invalid top-level properties for get only APIs. This PR adds behavior to the rule to examine get operations in addition to the put and patch operations that it already examined.