Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt MSAL managed identity implementation #24156

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Adopt MSAL managed identity implementation #24156

wants to merge 7 commits into from
+303 −634

Conversation

chlowell
Copy link
Member

Closes #20409. This is mostly straightforward refactoring, however the switch broke most of our tests because MSAL uses a per-process cache for managed identity tokens whereas we used a per-client cache.

@chlowell chlowell self-assigned this Feb 25, 2025
@chlowell chlowell marked this pull request as ready for review February 25, 2025 00:16
@chlowell chlowell requested review from jhendrixMSFT, RickWinter and a team as code owners February 25, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT Awaiting requested review from jhendrixMSFT jhendrixMSFT is a code owner

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@christothes christothes Awaiting requested review from christothes christothes is a code owner automatically assigned from Azure/azure-sdk-write-identity

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner automatically assigned from Azure/azure-sdk-write-identity

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner automatically assigned from Azure/azure-sdk-write-identity

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

@xiangyan99 xiangyan99 Awaiting requested review from xiangyan99 xiangyan99 is a code owner automatically assigned from Azure/azure-sdk-write-identity

@minhanh-phan minhanh-phan Awaiting requested review from minhanh-phan minhanh-phan is a code owner automatically assigned from Azure/azure-sdk-write-identity

At least 1 approving review is required to merge this pull request.

Assignees

@chlowell chlowell

Labels
Azure.Identity
Projects
Azure Identity SDK Improvements
Status: Untriaged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use MSAL for managed identity token requests
1 participant
@chlowell