Skip to content

Commit

Permalink
Small Change to isPauseOnStart (#40977)
Browse files Browse the repository at this point in the history
* init commit

* added recordingKind

* fixed typo

* added recordingKind

* changed tests for recordingKind
  • Loading branch information
amariwest-msft authored and v-vdharmaraj committed Jul 8, 2024
1 parent 7f50607 commit 738a794
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,8 @@ private StartCallRecordingRequestInternal getStartCallRecordingRequest(StartReco
request.setExternalStorage(recordingStorageInternal);
}
}
if (options.getPauseOnStart() != null) {
request.setPauseOnStart(options.getPauseOnStart());
if (options.isPauseOnStart() != null) {
request.setPauseOnStart(options.isPauseOnStart());
}

return request;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public String getRecordingId() {
}

/**
* Get the RecordingState property: The recording kind status of the recording.
* Get the RecordingKind property: The recording kind status of the recording.
*
* @return the recordingKind value.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ public StartRecordingOptions setRecordingFormat(RecordingFormat recordingFormat)
*
* @return pause on start.
*/
public Boolean getPauseOnStart() {
public Boolean isPauseOnStart() {
return pauseOnStart;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@
package com.azure.communication.callautomation;

import com.azure.communication.callautomation.implementation.models.RecordingStateInternal;
import com.azure.communication.callautomation.implementation.models.RecordingKind;
import com.azure.communication.callautomation.implementation.models.RecordingStateResponseInternal;

import com.azure.json.JsonProviders;
import com.azure.json.JsonWriter;

import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.util.AbstractMap;
Expand All @@ -18,9 +19,11 @@ public class CallRecordingUnitTestBase {
static final String SERVER_CALL_ID = "aHR0cHM6Ly9jb252LXVzd2UtMDguY29udi5za3lwZS5jb20vY29udi8tby1FWjVpMHJrS3RFTDBNd0FST1J3P2k9ODgmZT02Mzc1Nzc0MTY4MDc4MjQyOTM";

static final String RECORDING_ID = "recordingId";

private final RecordingStateResponseInternal recordingState = new RecordingStateResponseInternal().setRecordingId(RECORDING_ID);
private final String recordingActive = serializeObject(recordingState.setRecordingState(RecordingStateInternal.ACTIVE));
private final String recordingInactive = serializeObject(recordingState.setRecordingState(RecordingStateInternal.INACTIVE));

private final String recordingActive = generateGetParticipantResponse(RecordingStateInternal.ACTIVE, RecordingKind.TEAMS);
private final String recordingInactive = generateGetParticipantResponse(RecordingStateInternal.INACTIVE, RecordingKind.TEAMS);

ArrayList<AbstractMap.SimpleEntry<String, Integer>> recordingOperationsResponses = new ArrayList<>(Arrays.asList(
new AbstractMap.SimpleEntry<>(recordingActive, 200), //startRecording
Expand All @@ -42,4 +45,14 @@ private String serializeObject(RecordingStateResponseInternal o) {
throw new RuntimeException(e);
}
}

private String generateGetParticipantResponse(RecordingStateInternal recordingState, RecordingKind recordingKind) {

RecordingStateResponseInternal response = new RecordingStateResponseInternal();
response.setRecordingState(recordingState);
response.setRecordingKind(recordingKind);
response.setRecordingId(RECORDING_ID);

return serializeObject(response);
}
}

0 comments on commit 738a794

Please sign in to comment.