Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package property to decide whether a package requires API status check #1914

Closed
praveenkuttappan opened this issue Aug 17, 2021 · 2 comments
Closed

Add package property to decide whether a package requires API status check #1914

praveenkuttappan opened this issue Aug 17, 2021 · 2 comments
Assignees
@praveenkuttappan
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.

Comments

@praveenkuttappan
Copy link
Member

Currently API status check is enabled only for new data plane packages. Java team needs to enable API check for spring package also. We should add a property in package properties object that's default to true for new data plane package and use this property to decide whether to enable API status check or not. This property can be overridden if any language requires specific conditions or if extra package requires API status check.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 17, 2021
@praveenkuttappan praveenkuttappan self-assigned this Aug 17, 2021
@praveenkuttappan praveenkuttappan added APIView Central-EngSys This issue is owned by the Engineering System team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Aug 17, 2021
@praveenkuttappan praveenkuttappan mentioned this issue Aug 17, 2021
Merged
@mikekistler
Copy link
Member

@praveenkuttappan to check if this is already done.

@praveenkuttappan
Copy link
Member Author

Automatic API review support is already added for Java Spring SDK.

Repository owner moved this from 🤔Triage to 🎊Closed in Azure SDK EngSys 🤖🧠 Aug 16, 2022
@praveenkuttappan praveenkuttappan moved this to ✅ Done in ApiView Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@praveenkuttappan praveenkuttappan

Labels
APIView Central-EngSys This issue is owned by the Engineering System team.
Projects
ApiView
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@praveenkuttappan @mikekistler