Enable API review approval check for Java spring packages #1913
Conversation
praveenkuttappan
added
the
Central-EngSys
|
The following pipelines have been queued for testing: |
| @@ -140,7 +140,9 @@ if ($packages) | |||
| else | |||
| { | |||
| # Return error code if status code is 201 for new data plane package | |||
| if ($pkgInfo.SdkType -eq "client" -and $pkgInfo.IsNewSdk) | |||
| # Temporarily enable API review for spring SDK types. Ideally this should be done be using 'IsReviewRequired' method in language side | |||
There was a problem hiding this comment.
Do we expect this to be temporary? If so can you link to a issue adding that new property? Do we think just using IsNewSdk is enough? That will start bringing in mgmt libraries but that might also be desired.
There was a problem hiding this comment.
Python and few other languages didn't want the overhead of approving management packages so checking just the new SDK flag will be an issue immediately. I will file an issue for long term fix and link here.
|
@weshaggard : I have filed issue #1914 |
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
API review status check is done only for GA version of client SDK packages. Java team has asked to enable api review check for spring SDK also. I will make a change to add a function in individual language function script to override standard check of sdkType client. This PR is only a temp work around until language side override function is ready.