Use persistent HTTP client to speed up requests #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have to delete multiple blobs at once. This is quite anoying in Azure Blob storage in general, since it does not support batch deletes. So I need to send a request for each delete (multiple thousands in my case). The problem is made much worse by this library not keeping its HTTP connections open for successive requests. This commit fixes that by using the `Net:HTTP::Persistent` adapter from Faraday. This makes sending multiple requests much faster. On a bad connection it also causes less errors, since a connection timeout can only happen once. After connecting successfully the connection will continue working as TCP will handle any hicups, instead of getting `ETIMEDOUT` errors.
katmsft
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have to delete multiple blobs at once. This is quite anoying in Azure
Blob storage in general, since it does not support batch deletes. So I
need to send a request for each delete (multiple thousands in my case).
The problem is made much worse by this library not keeping its HTTP
connections open for successive requests. This commit fixes that by
using the
Net:HTTP::Persistentadapter from Faraday.This makes sending multiple requests much faster. On a bad connection it
also causes less errors, since a connection timeout can only happen
once. After connecting successfully the connection will continue
working as TCP will handle any hicups, instead of getting
ETIMEDOUTerrors.