Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New logging system #164

Merged
merged 7 commits into from
Sep 26, 2019
Merged

New logging system #164

merged 7 commits into from
Sep 26, 2019

Conversation

aalda
Copy link
Contributor

@aalda aalda commented Sep 25, 2019

No description provided.

@aalda aalda requested review from gdiazlo and jllucas September 25, 2019 13:53
gdiazlo
gdiazlo suggested changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@gdiazlo gdiazlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the documentation.

gdiazlo
gdiazlo reviewed Sep 25, 2019
View reviewed changes
Copy link
Contributor

@gdiazlo gdiazlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to discuss this and let it go in other change.

jllucas
jllucas reviewed Sep 26, 2019
View reviewed changes
jllucas
jllucas approved these changes Sep 26, 2019
View reviewed changes
Copy link

@jllucas jllucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalda aalda requested a review from gdiazlo September 26, 2019 10:08
gdiazlo
gdiazlo approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@gdiazlo gdiazlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aalda aalda merged commit a96b3f1 into BBVA:master Sep 26, 2019
@aalda aalda deleted the logging branch September 26, 2019 15:26
suizman pushed a commit that referenced this pull request Sep 30, 2019
@aalda
Merge pull request #164 from aalda/logging
c4b27bc 
New logging system

Former-commit-id: a96b3f1
suizman pushed a commit that referenced this pull request Sep 30, 2019
@aalda
Merge pull request #164 from aalda/logging
fbf2d7e 
New logging system

Former-commit-id: f00f2c5 [formerly a96b3f1]
Former-commit-id: c4b27bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdiazlo gdiazlo gdiazlo approved these changes

@jllucas jllucas jllucas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aalda @gdiazlo @jllucas