IA-3205 Backend for multi-projects #1557
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramj
force-pushed
the
IA-3205-multi-project
branch
from
2172381 to
fb5cb99
Compare
bramj
requested changes
Sep 30, 2024
There was a problem hiding this comment.
This PR works as advertised, and kudos for the good test coverage 👍
But I have some thoughts:
- If you're a user that also has access to the Projects module, the behaviour can be strange. You're allowed to create a new project, but you wont see it appear if you have a project assigned to yourself.
- As for in the user management. When you assign a project to yourself, you suddenly cannot assign another one since you don't have access to it. Remove it from your account and you can add everything again.
See video:
iaso-multi-project.mov
Another thought: should we show this filtering to the user as we do with Org unit limitations? It could help to avoid confusion like "Why am I not seeing all my data?"
|
Implemented here #1691 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend for multi-projects.
Related JIRA tickets : IA-3205
Changes
This PR is all about filtering.
Users can be associated with projects (
user.iaso_profile.projects):This PR uses this information to filter front-end lists.
When a user is linked to one or more projects:
If the user has no projects, he will continue to see all the projects linked to his account.
How to test
These lists should be filtered on user's projects by default (if any):
The API endpoint used for filtering projects should also filter on the user's projects by default (if any):