IA-3955: Ignore paging param on datasource api querry used to filter groups #1975
+138
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beygorghor
approved these changes
Feb 17, 2025
…i-querry-used-to-filter-groups
Updated the PR by adding and using dropdown endpoint for: The previous changes was breaking the data source page. But it's now fixed by the latest commits. |
beygorghor
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Thi s is ok for me, much better with a specific endpoint ! maybe a back-end review can be nice here @tdethier ?
…i-querry-used-to-filter-groups
tdethier
approved these changes
Feb 20, 2025
iaso/tests/api/test_data_sources.py
Outdated
| def test_dropdown_datasource(self): | ||
| self.client.force_authenticate(self.joe) | ||
| response = self.client.get("/api/datasources/dropdown/?order=name") | ||
| self.assertJSONResponse(response, 200) |
There was a problem hiding this comment.
I would add more asserts here:
- at least check if the received number of data sources matches what was expected
- maybe check the details of some of them (just the first one for instance), provided that there is some stable order
…thentication/permission for drop down datasource endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR solving? Explain here in one sentence.
Related JIRA tickets : IA-3955, IA-3894
Self proofreading checklist
Doc
Tell us where the doc can be found (docs folder, wiki, in the code...).
Changes
Get all data source linked to projects on the account!
How to test
From org unit groups page, try to filter on datasource and check in the browser network tab. The data source api query return all data source without page size.
Also try from the browser to access to dropdown endpoints for:
You can also sort group by source version.
Print screen / video
DataSource_Source-Version-List-.-Django-REST-framework.webm
Sort-Groups-by-sourceVersion.webm
Notes
Things that the reviewers should know:
Follow the Conventional Commits specification
The merge message of a pull request must follow the Conventional Commits specification.
This convention helps to automatically generate release notes.
Use lowercase for consistency.
Example:
Note that the Jira reference is preceded by a line break.
Both the line break and the Jira reference are entered in the Add an optional extended description… field.