Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA-3968: Navigation of pages (Orgunit Search) is reset to 1 after going to page 2 #1987

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

beygorghor
Copy link
Collaborator

@beygorghor beygorghor commented Feb 19, 2025

Filter org units by 'New' validation status (00:04)

Click the 'Search' button (00:06)

Navigate to page 2 (00:10)

Navigate to page 3 (00:17)

Observe the page reverts back to page 1 (00:20)

JamScreenRecording-IA-3968.webm

Related JIRA tickets : IA-3968

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Changes

Explain the changes that were made.

  • remove resetPageToOne logic
  • use TableWithDeepLink
  • new useQueryUpdateListener hook to watch a react-query dataset and trigger a function. on update

How to test

Launch a search on org units.
multi select some
Change you filters and search again, selection should be enmpty
Also make sure pagination is working corectly

Print screen / video

Screen.Recording.2025-02-19.at.15.58.16.mov

Follow the Conventional Commits specification

The merge message of a pull request must follow the Conventional Commits specification.

This convention helps to automatically generate release notes.

Use lowercase for consistency.

Example:

fix: empty instance pop up

Refs: IA-3665

Note that the Jira reference is preceded by a line break.

Both the line break and the Jira reference are entered in the Add an optional extended description… field.

@beygorghor beygorghor added the release Should be released in production at next deploy label Feb 20, 2025
@beygorghor beygorghor requested a review from hakifran February 21, 2025 09:15
Copy link
Contributor

@hakifran hakifran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Should be released in production at next deploy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants