Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos in README #8

Merged
merged 5 commits into from
Sep 18, 2023
Merged

fix: typos in README #8

merged 5 commits into from
Sep 18, 2023

Conversation

7yon
Copy link
Contributor

@7yon 7yon commented Jun 21, 2023

Resolves #7

@7yon 7yon requested a review from a team as a code owner June 21, 2023 18:45
@7yon 7yon requested review from volkodava and ugur-bb June 21, 2023 18:45
@7yon 7yon mentioned this pull request Jun 21, 2023
jjjasper
jjjasper previously approved these changes Jun 23, 2023
ugur-bb
ugur-bb previously approved these changes Jun 23, 2023
@@ -1,7 +1,7 @@
# Backbase Open Source

Welcome to Backbase's open source organisation. Regardless to if you are a customer, partner or employee you can create and share with everyone in the Backbase Community via this organisation.
Welcome to Backbase's open source organisation. Regardless of if you are a customer, partner, or employee you can create and share with everyone in the Backbase Community via this organisation.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Regardless of if ... -> Regardless if or Regardless of whether? (Because is sounds little weird otherwise.)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heading is Backbase Open Source, not Backbase's Open Source; hence, would be Backbase Open Source organisation instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, done ✅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind while updating to also change the links?

https://backbase.io/developers/

and

https://backbase.io/learning/

Also, I believe there are 2 versions of this text, one for the public view and one for the members. So this should be copied their too.

Thank you

Copy link
Contributor Author

@7yon 7yon Jun 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@craigwalkeruk links are updated ✅

I searched for the title of the README on GitHub to find a second page/text but this is the only file I found so far.
Maybe you could share a link to the 2nd file that should be updated as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ugur-bb @craigwalkeruk,
I adressed all comments, except one about the second version of this text that needs to be updated. Unfortunately I couldn't find it myself. Could you please help with it?

@7yon 7yon dismissed stale reviews from ugur-bb and jjjasper via a31f8f1 June 23, 2023 08:25
ugur-bb
ugur-bb previously approved these changes Jun 23, 2023
@ugur-bb ugur-bb requested a review from jjjasper June 23, 2023 09:05
@santam85 santam85 changed the title Fix typos in README fix: typos in README Sep 15, 2023
@santam85 santam85 mentioned this pull request Sep 18, 2023
@santam85 santam85 merged commit db27e6d into Backbase:main Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Typos in the README.md file
5 participants