-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typos in README #8
Conversation
profile/README.md
Outdated
@@ -1,7 +1,7 @@ | |||
# Backbase Open Source | |||
|
|||
Welcome to Backbase's open source organisation. Regardless to if you are a customer, partner or employee you can create and share with everyone in the Backbase Community via this organisation. | |||
Welcome to Backbase's open source organisation. Regardless of if you are a customer, partner, or employee you can create and share with everyone in the Backbase Community via this organisation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe Regardless of if ...
-> Regardless if
or Regardless of whether
? (Because is sounds little weird otherwise.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The heading is Backbase Open Source
, not Backbase's Open Source
; hence, would be Backbase Open Source organisation
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, done ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind while updating to also change the links?
https://backbase.io/developers/
and
Also, I believe there are 2 versions of this text, one for the public view and one for the members. So this should be copied their too.
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@craigwalkeruk links are updated ✅
I searched for the title of the README on GitHub to find a second page/text but this is the only file I found so far.
Maybe you could share a link to the 2nd file that should be updated as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ugur-bb @craigwalkeruk,
I adressed all comments, except one about the second version of this text that needs to be updated. Unfortunately I couldn't find it myself. Could you please help with it?
Resolves #7