Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pyproject.toml #323

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Remove pyproject.toml #323

merged 2 commits into from
Jun 20, 2023

Conversation

SagiPolaczek
Copy link
Collaborator

@SagiPolaczek SagiPolaczek commented Jun 19, 2023 •
edited
Loading

✅

Solves:

vscode failed to index packages with pyproject.toml along with a setup.py

@SagiPolaczek SagiPolaczek requested a review from mosheraboh June 19, 2023 09:12
mosheraboh
mosheraboh previously approved these changes Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@mosheraboh mosheraboh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SagiPolaczek SagiPolaczek merged commit 0afe317 into master Jun 20, 2023
@SagiPolaczek SagiPolaczek deleted the sagi/remove_pyproject.toml branch June 20, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosheraboh mosheraboh mosheraboh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SagiPolaczek @mosheraboh