add a method to add sample ids to a dataset #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SagiPolaczek
approved these changes
Aug 14, 2023
| def add_sample_ids_and_recreate( | ||
| self, added_sample_ids: List[Any], **kwargs: Dict | ||
| ) -> None: | ||
| self._orig_sample_ids = self._final_sample_ids + added_sample_ids |
There was a problem hiding this comment.
I suggest to use self.get_all_sample_ids() instead of self._final_sample_ids :)
There was a problem hiding this comment.
I think it is clearer to use _final_sample_ids, and it may be easier to track its use if the logic changes. Anyway, if you insist I will make your suggested change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supporting extending a dataset with new samples