whitelist: fix SECP256K1_WHITELIST_MAX_N_KEYS constant

"MAX" should mean inclusive. And the whitelisting functions handled this inconsistently.
BlockstreamResearch · Oct 15, 2021 · c8ac14d · c8ac14d
1 parent e290c0f
commit c8ac14d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/include/secp256k1_whitelist.h b/include/secp256k1_whitelist.h
@@ -13,7 +13,7 @@
 extern "C" {
 #endif
 
-#define SECP256K1_WHITELIST_MAX_N_KEYS	256
+#define SECP256K1_WHITELIST_MAX_N_KEYS 255
 
 /** Opaque data structure that holds a parsed whitelist proof
  *

diff --git a/src/modules/whitelist/main_impl.h b/src/modules/whitelist/main_impl.h
@@ -144,7 +144,7 @@ int secp256k1_whitelist_signature_parse(const secp256k1_context* ctx, secp256k1_
     }
 
     sig->n_keys = input[0];
-    if (sig->n_keys >= MAX_KEYS || input_len != 1 + 32 * (sig->n_keys + 1)) {
+    if (sig->n_keys > MAX_KEYS || input_len != 1 + 32 * (sig->n_keys + 1)) {
         return 0;
     }
     memcpy(&sig->data[0], &input[1], 32 * (sig->n_keys + 1));