Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing the ROI editor should warn if you have unsaved changes #161

Closed
2 tasks done
Breakthrough opened this issue Apr 29, 2024 · 2 comments
Closed
2 tasks done

Closing the ROI editor should warn if you have unsaved changes #161

Breakthrough opened this issue Apr 29, 2024 · 2 comments
Labels
bug
Milestone
v1.6.1

Comments

@Breakthrough
Copy link
Owner

Breakthrough commented Apr 29, 2024 •
edited
Loading

As per the discussion in #58, closing the region editor should warn the user if there are unsaved changes, and allow saving the region file. TODOs:

  • Prompt user to save before quitting if there are unsaved changes (fixed in 0e21304)
  • If a path was passed on command line to save the regions to, don't show a prompt for a file path, and always save there (e.g. dvr-scan -i video.mp4 -r -s regions.txt shouldn't show a file dialog)
@Breakthrough Breakthrough changed the title Closing the ROI editor with dvr-scan -s points.roi should save the file Closing the ROI editor should warn if you have unsaved changes Apr 29, 2024
@Breakthrough Breakthrough mentioned this issue Apr 29, 2024
Closed
@Breakthrough Breakthrough added this to the v1.6.1 milestone Apr 29, 2024
@Breakthrough
Copy link
Owner Author

The region editor will now always prompt if there are unsaved changes, including when starting a scan.

Breakthrough added a commit that referenced this issue May 11, 2024
@Breakthrough
[editor] Use save path if specified and always prompt on unsaved changes
12f54e1 
Fixes #161.
@Breakthrough
Copy link
Owner Author

Fixes will be included in v1.6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.6.1
Development

No branches or pull requests
1 participant
@Breakthrough