Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send repeated properties as repeated query parameters #147

Merged
merged 1 commit into from
Feb 7, 2016
Merged

Send repeated properties as repeated query parameters #147

merged 1 commit into from
Feb 7, 2016

Conversation

causal-agent
Copy link
Contributor

Fixes #146. Tested with google_gmail1::UserMessageListCall with multiple label IDs.

Byron added a commit that referenced this pull request Feb 7, 2016
Send repeated properties as repeated query parameters
@Byron Byron merged commit 4878fcb into Byron:master Feb 7, 2016
@Byron
Copy link
Owner

Byron commented Feb 7, 2016

Thank you, looks great !

@causal-agent
Copy link
Contributor Author

Can we get a release with this fix?

@Byron
Copy link
Owner

Byron commented Feb 28, 2016

Sure, I am preparing it as we speek, and new releases will trickle in on crates.io in the course of the day.

BTW: When using a subset of the functionality provided by a library, Rust will only pull in what you need. Thus, your binary should be slim - is this correct ?

@Byron
Copy link
Owner

Byron commented Feb 28, 2016

Interesting: A majority of the crates fail to build (and publish) due to our common friend:

make: *** [etc/api/tasks/v1/crates/0.1.12-api+20141121] Error 101
cd gen/proximitybeacon1_beta1 && cargo publish
    Updating registry `https://github.com/rust-lang/crates.io-index`
   Packaging google-proximitybeacon1_beta1 v0.1.12+20150729 (file:///Users/byron/Documents/dev/rust/google-apis-rs/gen/proximitybeacon1_beta1)
   Verifying google-proximitybeacon1_beta1 v0.1.12+20150729 (file:///Users/byron/Documents/dev/rust/google-apis-rs/gen/proximitybeacon1_beta1)
    Updating registry `https://github.com/rust-lang/crates.io-index`
   Compiling google-proximitybeacon1_beta1 v0.1.12+20150729 (file:///Users/byron/Documents/dev/rust/google-apis-rs/gen/proximitybeacon1_beta1/target/package/google-proximitybeacon1_beta1-0.1.12+20150729)
failed to verify package tarball

Caused by:
  failed to run custom build command for `google-proximitybeacon1_beta1 v0.1.12+20150729 (file:///Users/byron/Documents/dev/rust/google-apis-rs/gen/proximitybeacon1_beta1/target/package/google-proximitybeacon1_beta1-0.1.12+20150729)`
Process didn't exit successfully: `/Users/byron/Documents/dev/rust/google-apis-rs/target/debug/build/google-proximitybeacon1_beta1-21cfbed6f7e1a77d/build-script-build` (exit code: 101)
--- stderr
thread '<main>' panicked at 'assertion failed: (self.right != self.left)', /Users/byron/.multirust/cargo/registry/src/garden.eu.org-88ac128001ac3a9a/syntex_syntax-0.29.1/src/print/pp.rs:447

make: *** [etc/api/proximitybeacon/v1beta1/crates/0.1.12-api+20150729] Error 101
cd gen/blogger3 && cargo publish
    Updating registry `https://github.com/rust-lang/crates.io-index`
   Packaging google-blogger3 v0.1.12+20150422 (file:///Users/byron/Documents/dev/rust/google-apis-rs/gen/blogger3)
   Verifying google-blogger3 v0.1.12+20150422 (file:///Users/byron/Documents/dev/rust/google-apis-rs/gen/blogger3)
    Updating registry `https://github.com/rust-lang/crates.io-index`
   Compiling google-blogger3 v0.1.12+20150422 (file:///Users/byron/Documents/dev/rust/google-apis-rs/gen/blogger3/target/package/google-blogger3-0.1.12+20150422)
failed to verify package tarball

It's now reproducible on the host system as well (probably it has been all the time, but it's the first time I see it on my system anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants