Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update global session status, branch session status in txn #120

Merged
merged 2 commits into from
Jun 1, 2022

Conversation

dk-lockdown
Copy link
Collaborator

ref: https://github.com/cectc/dbpack/issues/

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

there are integration test cases

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #120 (ef17fd1) into dev (0ae8c77) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #120   +/-   ##
=======================================
  Coverage   48.23%   48.23%           
=======================================
  Files          55       55           
  Lines        5759     5759           
=======================================
  Hits         2778     2778           
  Misses       2738     2738           
  Partials      243      243           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ae8c77...ef17fd1. Read the comment docs.

@fatelei
Copy link
Collaborator

fatelei commented May 31, 2022

LGTM

@dk-lockdown dk-lockdown requested a review from hzliangbin May 31, 2022 07:42
Copy link
Collaborator

@bohehe bohehe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fatelei
Copy link
Collaborator

fatelei commented May 31, 2022

LGTM

@dk-lockdown dk-lockdown merged commit 9829387 into CECTC:dev Jun 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants