Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support cross-database update transactions #193

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

dk-lockdown
Copy link
Collaborator

ref: https://github.com/cectc/dbpack/issues/

Ⅰ. Describe what this PR did

If the update operation needs to be executed on multiple database shards, the distributed transaction should be coordinated to ensure the atomicity of the update operation.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #193 (a19ae9d) into dev (9e741de) will decrease coverage by 0.20%.
The diff coverage is 2.22%.

@@            Coverage Diff             @@
##              dev     #193      +/-   ##
==========================================
- Coverage   46.36%   46.16%   -0.21%     
==========================================
  Files          77       77              
  Lines        8713     8751      +38     
==========================================
  Hits         4040     4040              
- Misses       4286     4323      +37     
- Partials      387      388       +1     
Impacted Files Coverage Δ
pkg/plan/delete.go 7.27% <0.00%> (ø)
pkg/plan/update.go 10.52% <2.32%> (-5.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e741de...a19ae9d. Read the comment docs.

@dk-lockdown dk-lockdown added enhancement New feature or request sharding Sharding db and sharding table labels Jul 11, 2022
Copy link
Collaborator

@bohehe bohehe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dk-lockdown dk-lockdown merged commit b184688 into CECTC:dev Jul 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request sharding Sharding db and sharding table
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants