Fix: debloat fails with 'can't set attribute' (#48)

CERT-Polska · May 22, 2023 · 41e289d · 41e289d
1 parent f1ae540
commit 41e289d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/karton/archive_extractor/__version__.py b/karton/archive_extractor/__version__.py
@@ -1 +1 @@
-__version__ = "1.4.0"
+__version__ = "1.4.1"
diff --git a/karton/archive_extractor/archive_extractor.py b/karton/archive_extractor/archive_extractor.py
@@ -155,17 +155,19 @@ def process(self, task: Task) -> None:
                 )
                 continue
 
-            if len(child.contents) > self.max_size:
-                if child.contents[:2] == b"MZ":
-                    debloated = self.debloat_pe(child.contents)
+            contents = child.contents
+
+            if len(contents) > self.max_size:
+                if contents[:2] == b"MZ":
+                    debloated = self.debloat_pe(contents)
                     if debloated is not None:
-                        child.contents = debloated
+                        contents = debloated
 
             # Is it still too big?
-            if len(child.contents) > self.max_size:
+            if len(contents) > self.max_size:
                 self.log.warning(
                     "Child is too big for further processing (%d > %d)",
-                    len(child.contents),
+                    len(contents),
                     self.max_size,
                 )
                 continue
@@ -177,7 +179,7 @@ def process(self, task: Task) -> None:
                     "quality": task.headers.get("quality", "high"),
                 },
                 payload={
-                    "sample": Resource(fname, child.contents),
+                    "sample": Resource(fname, contents),
                     "parent": sample,
                     "extraction_level": extraction_level + 1,
                 },