Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hugr-py doesn't set extension_reqs on custom ops #1758

Closed
aborgna-q opened this issue Dec 10, 2024 · 0 comments · Fixed by #1759
Closed

hugr-py doesn't set extension_reqs on custom ops #1758

aborgna-q opened this issue Dec 10, 2024 · 0 comments · Fixed by #1759
Assignees
@aborgna-q
Labels
bug Something isn't working python Pull requests that update Python code
Milestone
hugr-rs 0.14 / hu...

Comments

@aborgna-q
Copy link
Collaborator

The ops should require the extensions where they are defined
@aborgna-q aborgna-q added bug Something isn't working python Pull requests that update Python code labels Dec 10, 2024
@aborgna-q aborgna-q self-assigned this Dec 10, 2024
This was referenced Dec 10, 2024
Merged
Merged
@aborgna-q aborgna-q added this to the hugr-rs 0.14 / hugr-py 0.10 milestone Dec 10, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 10, 2024
@aborgna-q
fix: hugr-py not adding extension-reqs on custom ops (#1759)
97ba7f4 
Fixes #1758 

Without these changes, the validation tests fail if we remove the
workaround in `custom.rs`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborgna-q aborgna-q

Labels
bug Something isn't working python Pull requests that update Python code
Projects
None yet
Milestone
hugr-rs 0.14 / hugr-py 0.10
Development

Successfully merging a pull request may close this issue.

fix: hugr-py not adding extension-reqs on custom ops CQCL/hugr
1 participant
@aborgna-q