Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpaqueValue / CustomConst should have a Weak<Extension> ref #1775

Closed
aborgna-q opened this issue Dec 12, 2024 · 1 comment
Closed

OpaqueValue / CustomConst should have a Weak<Extension> ref #1775

aborgna-q opened this issue Dec 12, 2024 · 1 comment
Labels
breaking-change Changes that break semver

Comments

@aborgna-q
Copy link
Collaborator

No description provided.

@aborgna-q aborgna-q added the breaking-change Changes that break semver label Dec 12, 2024
@doug-q
Copy link
Collaborator

doug-q commented Dec 12, 2024

Dup of #1742 :)

This issue buries the lede, CustomConsts are not currently registered via Extensions. Surely that must happen first for this to be meaningful.

See #1225, and also #1224

@ss2165 ss2165 mentioned this issue Dec 12, 2024
Merged
@aborgna-q aborgna-q closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 12, 2024
@ss2165
feat!: rename extension_reqs to runtime_reqs (#1776)
5f5bce4 
Closes #1734
CustomConst::extension_reqs not renamed because they still refer to the
extensions where they are defined. this should be updated to references
to match ops and types #1775

BREAKING CHANGE: `extension_reqs` field in FunctionType and Extension
renamed to `runtime_reqs`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change Changes that break semver
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aborgna-q @doug-q